Gecko [ v99win.today ]

Name	Size	Permission
git-SEM_VALUE_MAX.diff	600 B	-rw-r--r--
git-WAIT.diff	1.44 KB	-rw-r--r--
git-barrier-1.diff	694 B	-rw-r--r--
git-bsd4.3-ioctls.diff	873 B	-rw-r--r--
git-clock-cputime.diff	2.86 KB	-rw-r--r--
git-cond_destroy.diff	6.02 KB	-rw-r--r--
git-cthreads-symbols.diff	1.03 KB	-rw-r--r--
git-cthreads.diff	21.02 KB	-rw-r--r--
git-fexecve.diff	1.2 KB	-rw-r--r--
git-fix-longjmp.diff	3.03 KB	-rw-r--r--
git-fork-pthread_exit.diff	1.23 KB	-rw-r--r--
git-futex-internal.diff	1.82 KB	-rw-r--r--
git-holes.diff	1.42 KB	-rw-r--r--
git-hurd-version.diff	1.02 KB	-rw-r--r--
git-hurdsig-SA_SIGINFO.diff	20.64 KB	-rw-r--r--
git-intr-msg-unwind.diff	1.23 KB	-rw-r--r--
git-ld-library-path-checks.dif...	3.57 KB	-rw-r--r--
git-libc-open.diff	970 B	-rw-r--r--
git-libpthread-nodelete.diff	771 B	-rw-r--r--
git-libpthread-testcancel.diff	1.21 KB	-rw-r--r--
git-libpthread_plt.diff	1.24 KB	-rw-r--r--
git-libpthread_syms.diff	4.68 KB	-rw-r--r--
git-lll-initializer.diff	3.15 KB	-rw-r--r--
git-lll-private.diff	611 B	-rw-r--r--
git-lll-ptr.diff	19.54 KB	-rw-r--r--
git-lll-wait-intr.diff	5.41 KB	-rw-r--r--
git-longjmp-onstack.diff	9.07 KB	-rw-r--r--
git-mmap-EINVAL.diff	668 B	-rw-r--r--
git-mmap_addr.diff	1.43 KB	-rw-r--r--
git-posix_openpt.diff	2.71 KB	-rw-r--r--
git-pselect.diff	5.72 KB	-rw-r--r--
git-pthread_atfork-hidden.diff	1.9 KB	-rw-r--r--
git-pthread_get_cleanup_stack....	2.43 KB	-rw-r--r--
git-pthread_link_tests.diff	1.86 KB	-rw-r--r--
git-pthread_self.diff	1.16 KB	-rw-r--r--
git-raise.diff	1.08 KB	-rw-r--r--
git-register-atfork.diff	7.98 KB	-rw-r--r--
git-register-atfork2.diff	1.1 KB	-rw-r--r--
git-sbrk-end.diff	5.13 KB	-rw-r--r--
git-sched_sets.diff	3.13 KB	-rw-r--r--
git-sem-intr.diff	4.85 KB	-rw-r--r--
git-sem-open-init.diff	2.51 KB	-rw-r--r--
git-sem-open.diff	31.92 KB	-rw-r--r--
git-sem-pshared.diff	15.5 KB	-rw-r--r--
git-siginfo_uesp.diff	811 B	-rw-r--r--
git-sigstate_thread_reference....	3.71 KB	-rw-r--r--
git-spin_lock.diff	829 B	-rw-r--r--
git-ss_init.diff	1.15 KB	-rw-r--r--
git-strtol-test.diff	1.47 KB	-rw-r--r--
git-tiocflush.diff	976 B	-rw-r--r--
git-trunc-times.diff	1.13 KB	-rw-r--r--
git-tst-udp.diff	3.43 KB	-rw-r--r--
git-waitid.diff	5.65 KB	-rw-r--r--
local-ED.diff	1.21 KB	-rw-r--r--
local-clock_gettime_MONOTONIC....	3.38 KB	-rw-r--r--
local-disable-ioctls.diff	1.53 KB	-rw-r--r--
local-enable-ldconfig.diff	1.15 KB	-rw-r--r--
local-exec_filename.diff	4.35 KB	-rw-r--r--
local-fix-nss.diff	1.37 KB	-rw-r--r--
local-mach_print.diff	658 B	-rw-r--r--
local-madvise_warn.diff	553 B	-rw-r--r--
local-no-bootstrap-fs-access.d...	786 B	-rw-r--r--
local-no_unsupported_ioctls.di...	2.14 KB	-rw-r--r--
local-tls-ie-align.diff	1.08 KB	-rw-r--r--
local-usr.diff	593 B	-rw-r--r--
submitted-AF_LINK.diff	1.08 KB	-rw-r--r--
submitted-bind_umask2.diff	1.65 KB	-rw-r--r--
submitted-net.diff	81.49 KB	-rw-r--r--
submitted-path_mounted.diff	1.41 KB	-rw-r--r--
sysvshm-lll.diff	532 B	-rw-r--r--
tg-EGREGIOUS-fr.diff	794 B	-rw-r--r--
tg-EIEIO-fr.diff	805 B	-rw-r--r--
tg-bigmem.diff	1.42 KB	-rw-r--r--
tg-bits_atomic.h_multiple_thre...	11.56 KB	-rw-r--r--
tg-bootstrap.diff	775 B	-rw-r--r--
tg-eintr.diff	786 B	-rw-r--r--
tg-glibc-2.24-restore-malloc-h...	548 B	-rw-r--r--
tg-hooks.diff	2.49 KB	-rw-r--r--
tg-ifaddrs_v6.diff	10.71 KB	-rw-r--r--
tg-libc_rwlock_recursive.diff	3.61 KB	-rw-r--r--
tg-mach-hurd-link.diff	987 B	-rw-r--r--
tg-sendmsg-SCM_CREDS.diff	8.03 KB	-rw-r--r--
tg-sysvshm.diff	21.62 KB	-rw-r--r--
tg-thread-cancel.diff	2.81 KB	-rw-r--r--
tg-unlockpt-chroot.diff	741 B	-rw-r--r--
unsubmitted-clock_t_centisecon...	1.79 KB	-rw-r--r--
unsubmitted-getaux_at_secure.d...	637 B	-rw-r--r--
unsubmitted-mremap.diff	838 B	-rw-r--r--
unsubmitted-prof-eintr.diff	668 B	-rw-r--r--

Code Editor : git-sbrk-end.diff

Committed for glibc 2.33

commit 8c6beab4e1c03ac57150241015486e3f497c17cc
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date:   Wed Aug 5 23:48:58 2020 +0200

hurd: Rework sbrk
    
    Making the brk start exactly at the end of the main application binary was
    requiring to get it through the _end symbol, which does not work any more
    with recent toolchains, and actually produces in libc.so a confusing
    external _end symbol that produces odd results, see
    https://sourceware.org/bugzilla/show_bug.cgi?id=23499
    
    Trying to do so is quite outdated anyway with the tendency for address
    randomization.
    
    Using _end was also allowing to include the main binary data within
    the RLIMIT_DATA, but this also seems outdated with dynamic library
    loading, and nowadays' memory consumption via malloc and mmap rather than
    statically-allocated data.
    
    This adds a BRK_START macro in <vm_param.h> that just tells where we
    want to start the brk, and thus removes the _end symbol.
    
    * sysdeps/mach/hurd/i386/vm_param.h: New file.
    * sysdeps/mach/hurd/brk.c: Use BRK_START as brk start instead of _end.
    Also ignore __data_start.
    * hurd/Versions: Remove _end symbol.
    * sysdeps/mach/hurd/i386/libc.abilist: Remove _end symbol.

---
 hurd/Versions                       |  3 ---
 sysdeps/mach/hurd/brk.c             | 16 ++++++------
 sysdeps/mach/hurd/i386/libc.abilist |  1 -
 sysdeps/mach/hurd/i386/vm_param.h   | 24 ++++++++++++++++++
 4 files changed, 32 insertions(+), 12 deletions(-)

diff --git a/hurd/Versions b/hurd/Versions
index f5e8b8cb32..9b5448ab2f 100644
--- a/hurd/Versions
+++ b/hurd/Versions
@@ -1,8 +1,5 @@
 libc {
   GLIBC_2.0 {
-    # necessary for the Hurd brk implementation
-    _end;
-
     # variables used in macros & inline functions
     __hurd_threadvar_stack_mask; __hurd_threadvar_stack_offset;
 
diff --git a/sysdeps/mach/hurd/brk.c b/sysdeps/mach/hurd/brk.c
index 4fac03fcc3..a6d4880028 100644
--- a/sysdeps/mach/hurd/brk.c
+++ b/sysdeps/mach/hurd/brk.c
@@ -19,6 +19,7 @@
 #include <hurd.h>
 #include <hurd/resource.h>
 #include <cthreads.h>		/* For `struct mutex'.  */
+#include <vm_param.h>
 
 
 /* Initial maximum size of the data segment (this is arbitrary).  */
@@ -39,9 +40,7 @@ weak_alias (_hurd_brk, ___brk_addr)
 
 struct mutex _hurd_brk_lock;
 
-extern int __data_start, _end;
-weak_extern (__data_start)
-static vm_address_t static_data_start;
+static vm_address_t brk_start;
 
 
 /* Set the end of the process's data space to INADDR.
@@ -91,7 +90,7 @@ _hurd_set_brk (vm_address_t addr)
   rlimit = _hurd_rlimits[RLIMIT_DATA].rlim_cur;
   __mutex_unlock (&_hurd_rlimit_lock);
 
-  if (addr - static_data_start > rlimit)
+  if (addr - brk_start > rlimit)
     {
       /* Need to increase the resource limit.  */
       errno = ENOMEM;
@@ -138,17 +137,18 @@ init_brk (void)
 
   __mutex_init (&_hurd_brk_lock);
 
-  static_data_start = (vm_address_t) (&__data_start ?: &_end);
+  brk_start = (vm_address_t) BRK_START;
 
   /* If _hurd_brk is already set, don't change it.  The assumption is that
      it was set in a previous run before something like Emacs's unexec was
      called and dumped all the data up to the break at that point.  */
-  if (_hurd_brk == 0)
-    _hurd_brk = (vm_address_t) &_end;
+  if (_hurd_brk == 0) {
+    _hurd_brk = (vm_address_t) BRK_START;
+  }
 
   pagend = round_page (_hurd_brk);
 
-  _hurd_data_end = round_page (static_data_start + DATA_SIZE);
+  _hurd_data_end = round_page (brk_start + DATA_SIZE);
 
   if (pagend < _hurd_data_end)
     {
diff --git a/sysdeps/mach/hurd/i386/libc.abilist b/sysdeps/mach/hurd/i386/libc.abilist
index 5f6154d518..72537218ba 100644
--- a/sysdeps/mach/hurd/i386/libc.abilist
+++ b/sysdeps/mach/hurd/i386/libc.abilist
@@ -554,7 +554,6 @@ GLIBC_2.2.6 __xstat64 F
 GLIBC_2.2.6 _authenticate F
 GLIBC_2.2.6 _dl_mcount_wrapper F
 GLIBC_2.2.6 _dl_mcount_wrapper_check F
-GLIBC_2.2.6 _end D 0x0
 GLIBC_2.2.6 _environ D 0x4
 GLIBC_2.2.6 _exit F
 GLIBC_2.2.6 _flushlbf F
diff --git a/sysdeps/mach/hurd/i386/vm_param.h b/sysdeps/mach/hurd/i386/vm_param.h
new file mode 100644
index 0000000000..96230bc149
--- /dev/null
+++ b/sysdeps/mach/hurd/i386/vm_param.h
@@ -0,0 +1,24 @@
+/* Copyright (C) 2020 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#ifndef _I386_VM_PARAM_H
+#define _I386_VM_PARAM_H
+
+/* Arbitrary start of the brk. This is after usual binary and library mappings.  */
+#define BRK_START	0x10000000
+
+#endif /* i386/vm_param.h */

${this.title}

Code Editor : git-sbrk-end.diff